Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Extract truncation logic out of partial concatenation in P2P rechunking #8826

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

hendrikmakait
Copy link
Member

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait marked this pull request as ready for review August 9, 2024 16:33
@hendrikmakait hendrikmakait requested a review from fjetter as a code owner August 9, 2024 16:33
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ±0      25 suites  ±0   10h 14m 16s ⏱️ + 6m 15s
 4 104 tests ±0   3 987 ✅ +5    113 💤 ±0  4 ❌  - 5 
47 426 runs  ±0  45 293 ✅ +5  2 129 💤 ±0  4 ❌  - 5 

For more details on these failures, see this check.

Results for commit 762bfc2. ± Comparison against base commit e364f42.

Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phofl phofl merged commit 86dc83c into dask:main Aug 12, 2024
26 of 32 checks passed
@hendrikmakait hendrikmakait deleted the extract-truncation-from-concatenation branch August 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants