Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid key validation if validation is disabled #8822

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Aug 7, 2024

This breaks off #8797

another small perf fix I encountered for very large graphs (only a couple percent of CPU time but still unnecessary). We typically disable validation and at this point I don't see a reason why this should be enabled at runtime.

This check essentially validates that all "keys" are of type {bytes, int, float, str} or a tuple that is made of those types.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   12h 1m 19s ⏱️ + 5m 17s
 4 102 tests ±0   3 984 ✅  - 4    111 💤 ±0   7 ❌ + 4 
55 493 runs  ±0  53 049 ✅  - 9  2 430 💤  - 1  14 ❌ +10 

For more details on these failures, see this check.

Results for commit 65ae7ea. ± Comparison against base commit 92fc0e2.

@phofl phofl merged commit 845c07a into dask:main Aug 8, 2024
24 of 35 checks passed
@phofl
Copy link
Collaborator

phofl commented Aug 8, 2024

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants