Update pre-commit hooks
#8444
Merged
Update pre-commit hooks
#8444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 9h 36m 22s ⏱️ - 6m 21s For more details on these failures, see this check. Results for commit 7b18917. ± Comparison against base commit 7562f9c. ♻️ This comment has been updated with latest results. |
jrbourbeau
reviewed
Jan 9, 2024
distributed/client.py
Outdated
| @@ -2188,7 +2188,7 @@ async def _gather(self, futures, errors="raise", direct=None, local_worker=None) | |||
| "Cannot gather Futures created by another client. " | |||
| f"These are the {len(mismatched_futures)} (out of {len(futures)}) " | |||
| f"mismatched Futures and their client IDs (this client is {self.id}): " | |||
| f"{ {f: f.client.id for f in mismatched_futures} }" | |||
| f"{{f: f.client.id for f in mismatched_futures}}" | |||
There was a problem hiding this comment.
It looks like this update results in a genuine behavior change (TIL)
In [1]: f"{ {i:i for i in range(10)} }"
Out[1]: '{0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6, 7: 7, 8: 8, 9: 9}'
In [2]: f"{{i:i for i in range(10)}}"
Out[2]: '{i:i for i in range(10)}'Can we add an ignore or something to this line?
There was a problem hiding this comment.
Good catch, I wasn't aware of that! Fixed
jrbourbeau
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #xxxx
pre-commit run --all-files