Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop runtime dependency to setuptools #6017

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Mar 29, 2022

setuptools now remains exclusively in setup.py and conda meta.yaml.
It is also optionally used by versioneer, with a transparent fallback to distutils if it's not already loaded.

twin of

xrefs

@crusaderky
Copy link
Collaborator Author

I can see a wealth of differences between

  • dask/continuous_integration/recipe/meta.yaml
    and
  • distributed/continuous_integration/recipes/dask/meta.yaml

I expect one of the two files to be unused?

CC @jsignell

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

Unit Test Results

       12 files  +       4         12 suites  +4   6h 38m 10s ⏱️ + 2h 37m 5s
  2 675 tests +       3    2 591 ✔️ +     12    81 💤  -   11  3 +2 
15 954 runs  +5 298  15 089 ✔️ +5 012  862 💤 +284  3 +2 

For more details on these failures, see this check.

Results for commit a7896e9. ± Comparison against base commit ed48736.

♻️ This comment has been updated with latest results.

@crusaderky
Copy link
Collaborator Author

All failures unrelated.
linting failure: #6019

@jsignell
Copy link
Member

My understanding is that there recipes are exclusively used for nightly builds. @charlesbluca @jakirkham

@charlesbluca
Copy link
Member

My understanding is that there recipes are exclusively used for nightly builds

Correct, both are used in this workflow to build / publish nightlies on every commit.

I expect one of the two files to be unused?

Both are being used, with dask/continuous_integration/recipe/meta.yaml generating dask-core nightlies and distributed/continuous_integration/recipes/dask/meta.yaml generating dask metapackage nightlies

@crusaderky crusaderky merged commit 852d5f5 into dask:main Mar 29, 2022
@crusaderky crusaderky deleted the setuptools branch March 29, 2022 22:00
mrocklin pushed a commit to mrocklin/distributed that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants