Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Services for out-of-band operations #5948

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[Draft] Services for out-of-band operations #5948

wants to merge 18 commits into from

Commits on Mar 16, 2022

  1. Initial interface for Services

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    3725b10 View commit details
    Browse the repository at this point in the history

  2. rename to ServiceGroup

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    eeebc6a View commit details
    Browse the repository at this point in the history

  3. rename to ServiceTask

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    5e9ea38 View commit details
    Browse the repository at this point in the history

  4. docs, and numerous other changes

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    6743ff2 View commit details
    Browse the repository at this point in the history

  5. ServiceTask type -> ServiceKey

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    78fd4ff View commit details
    Browse the repository at this point in the history

  6. ServiceTask terminology -> service task

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f40cc9a View commit details
    Browse the repository at this point in the history

  7. opaque service IDs instead of addrs

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    73e9c25 View commit details
    Browse the repository at this point in the history

  8. Service as an ABC

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    44418bf View commit details
    Browse the repository at this point in the history

  9. simple service layer

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    b0e30d6 View commit details
    Browse the repository at this point in the history

  10. fix add_key docstring

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    717f6da View commit details
    Browse the repository at this point in the history

  11. output_ready/get_output instead of produce_key 

    This way, the output tasks actually run. It's less weird. Can tasks depend on multiple Services now? Can the scheduler automatically deal with triangle fusion? See the next commit!
    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f1d977e View commit details
    Browse the repository at this point in the history

  12. Allow tasks to depend on multiple services 

    The goal of service families is to solve triangle fusion, but that's probably not a good idea. This is really complicated. And the assurance that services in the same service family will distribute outputs in the same way, or even have the same ouputs at all, is tenuous.
    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    d84ce78 View commit details
    Browse the repository at this point in the history

  13. slightly better definition of service families 

    Still doesn't seem like a great idea. Can think of other use-cases where you'd want the sibling services to run on different workers (GPU?), then transfer stuff at the end.
    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    ba08e61 View commit details
    Browse the repository at this point in the history

  14. Revert output_ready and service families 

    `output_ready` can/should probably stay. But service families seem like too much right now. Not sure how else to handle triangle fusion though (besides just not letting the tasks fuse).

This reverts commits ba08e61 d84ce78 f1d977e
    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    685cb1a View commit details
    Browse the repository at this point in the history

  15. leader as ID, not bool

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    f529f93 View commit details
    Browse the repository at this point in the history

  16. please_evict

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    29872dc View commit details
    Browse the repository at this point in the history

  17. all_inputs_done

    @gjoseph92
    gjoseph92 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    624bc5f View commit details
    Browse the repository at this point in the history

  18. clarify docstring

    @gjoseph92
    gjoseph92 authored Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1ac83b7 View commit details
    Browse the repository at this point in the history