-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Service
s for out-of-band operations
#5948
Draft
gjoseph92
wants to merge
18
commits into
dask:main
Choose a base branch
from
gjoseph92:services
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Mar 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3725b10 - Browse repository at this point
Copy the full SHA 3725b10View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeebc6a - Browse repository at this point
Copy the full SHA eeebc6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e9ea38 - Browse repository at this point
Copy the full SHA 5e9ea38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6743ff2 - Browse repository at this point
Copy the full SHA 6743ff2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78fd4ff - Browse repository at this point
Copy the full SHA 78fd4ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for f40cc9a - Browse repository at this point
Copy the full SHA f40cc9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73e9c25 - Browse repository at this point
Copy the full SHA 73e9c25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44418bf - Browse repository at this point
Copy the full SHA 44418bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0e30d6 - Browse repository at this point
Copy the full SHA b0e30d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 717f6da - Browse repository at this point
Copy the full SHA 717f6daView commit details -
output_ready
/get_output
instead ofproduce_key
This way, the output tasks actually run. It's less weird. Can tasks depend on multiple Services now? Can the scheduler automatically deal with triangle fusion? See the next commit!
Configuration menu - View commit details
-
Copy full SHA for f1d977e - Browse repository at this point
Copy the full SHA f1d977eView commit details -
Allow tasks to depend on multiple services
The goal of service families is to solve triangle fusion, but that's probably not a good idea. This is really complicated. And the assurance that services in the same service family will distribute outputs in the same way, or even have the same ouputs at all, is tenuous.
Configuration menu - View commit details
-
Copy full SHA for d84ce78 - Browse repository at this point
Copy the full SHA d84ce78View commit details -
slightly better definition of service families
Still doesn't seem like a great idea. Can think of other use-cases where you'd want the sibling services to run on different workers (GPU?), then transfer stuff at the end.
Configuration menu - View commit details
-
Copy full SHA for ba08e61 - Browse repository at this point
Copy the full SHA ba08e61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 685cb1a - Browse repository at this point
Copy the full SHA 685cb1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f529f93 - Browse repository at this point
Copy the full SHA f529f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29872dc - Browse repository at this point
Copy the full SHA 29872dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 624bc5f - Browse repository at this point
Copy the full SHA 624bc5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ac83b7 - Browse repository at this point
Copy the full SHA 1ac83b7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.