-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent data duplication on unspill #5936
Conversation
crusaderky
commented
Mar 11, 2022
•
edited
Loading
edited
- Closes Spill to disk may cause data duplication #3756
- Blocked by New class zict.Cache zict#65
0926bcc
to
ae5edf5
Compare
Unit Test Results 12 files ± 0 12 suites ±0 5h 48m 34s ⏱️ + 1m 22s For more details on these failures, see this check. Results for commit 398783d. ± Comparison against base commit 2fffe74. ♻️ This comment has been updated with latest results. |
4bec938
to
7843d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Looking forward to having this in! Changes LGTM once zict is merged, etc.
7843d4f
to
f4c649c
Compare
assert buf.slow.weight_by_key == {"a": psize(a)} | ||
assert_buf(buf, {"bad": bad}, {"a": a}) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new test start here; everything else in this module is just a refactor
Removed blockers |