Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolufy-imports - No relative - PEP8 #5924

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Mar 10, 2022

Closes #5889

Alternative to #5917

Co-authored-by: MarcoGorelli <marcogorelli@protonmail.com>
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this approach and happy that we don't really need to justify it since it aligns with pep8.

@github-actions
Copy link
Contributor

Unit Test Results

       12 files  ±0         12 suites  ±0   5h 41m 40s ⏱️ - 6m 9s
  2 639 tests ±0    2 556 ✔️ +1    80 💤 ±0  3  - 1 
12 977 runs  ±0  12 334 ✔️ +2  639 💤  - 1  4  - 1 

For more details on these failures, see this check.

Results for commit 22d471f. ± Comparison against base commit 30f0b60.

@MarcoGorelli MarcoGorelli mentioned this pull request Mar 14, 2022
3 tasks
@crusaderky crusaderky merged commit 85bf1be into dask:main Mar 14, 2022
@crusaderky
Copy link
Collaborator

This looks good. Thank you!

@martindurant
Copy link
Member

Is there a tool to do this kind of refactor?

@MarcoGorelli
Copy link

Yes, the one just added to .pre-commit-config.yaml:

  -   repo: https://github.com/MarcoGorelli/absolufy-imports
      rev: v0.3.1
      hooks:
      - id: absolufy-imports
        name: absolufy-imports

@martindurant
Copy link
Member

Got it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Absolute vs Relative imports
5 participants