Add possibility of spill to constrained disk [WIP] #5521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesThis is the start of a PR that will add the possibility to spill to a constrained disk. Things are not quite working yet but wanted to have a draft up.
Tried using a custom
__setitem__do doesn't use thesuper()see:https://github.com/ncclementi/distributed/blob/81b12da2dcc1a6b958b4e4db4682bade536d7d41/distributed/spill.py#L91-L94
BUt the problem I'm having is that is not keeping the key on fast, but spilling it to disk. I think this is because of the way LRU works.