Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we try to split up large messages in comms.
This is useful in a few situations:
small messages
of an int
We correctly cut up data frames into smaller pieces to address these
issues. However we don't apply this same logic to the header frame,
which may still contain very large bytestrings. This commit adds a
workaround in protocol dumps/loads which watches for this event and
splits the header frame up if necessary.
It works, but it's not very smooth. I would prefer that in the future
we think about what a proper header should look like and ensure that it
contains no user data. In the meantime this should help.
cc @ian-r-rose @jakirkham