Deprecate utilities which have moved to dask #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
I think my browser is broken. It shows green checkmarks for all the builds. that must be a bug.
Thanks @jrbourbeau !
This was referenced Jun 24, 2021
TomAugspurger
pushed a commit
to TomAugspurger/dask-gateway
that referenced
this pull request
Aug 5, 2021
dask/distributed#4966 deprecated `distributed.utils.format_bytes`. We should use the version from `dask.utils`. I didn't check the exact version of Dask it was added, but it was >2 years ago, so I think we're OK.
martindurant
pushed a commit
to dask/dask-gateway
that referenced
this pull request
Aug 13, 2021
dask/distributed#4966 deprecated `distributed.utils.format_bytes`. We should use the version from `dask.utils`. I didn't check the exact version of Dask it was added, but it was >2 years ago, so I think we're OK.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several utilities, e.g.
distributed.utils.parse_timedelta, have been moved over todask.utilsbut we've keptimports around indistributed/utils.pyfor backwards compatibility. This PR officially deprecates utilities which have migrated fromdistributedtodask.