Ensure connectionpool does not leave comms if closed mid connect #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I retriggered the run to see if the register_backend_entrypoint issue persists |
|
The register_backend_entrypoint issue seems to be unrelated (I believe) but is still persistent, see #4961 |
mrocklin
reviewed
Jun 23, 2021
| # We might still have tasks haning in the semaphore. This will let them | ||
| # run into an exception and raise a commclosed | ||
| while self._n_connecting: | ||
| await asyncio.sleep(0.005) |
There was a problem hiding this comment.
Just checking, the finally block is triggered when we cancel?
There was a problem hiding this comment.
Yes. That's covered in the test, ensured by assert pool._connecting in line 651
|
+1 from me |
Co-authored-by: Matthew Rocklin <mrocklin@gmail.com>
fjetter
force-pushed
the
connectionpool_close
branch
from
66b9a16
to
14c10af
Compare
jrbourbeau
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a chance for the
ConnectionPoolto leave connections open even after it was closed.This came up during #4734