Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure exceptions in handlers are handled equally for sync and async #4734

Closed
wants to merge 8 commits into from
Closed

Ensure exceptions in handlers are handled equally for sync and async #4734

wants to merge 8 commits into from
+372 −116

Commits on Jul 14, 2021

  1. keep dependents in worker dependency if TS is still known 

    Unless the task is entirely forgotten by
the worker it is confusing behaviour if
the dependent or a task is removed
once it finished executing. if this
information is required a dedicated
dynamic attribute should be used like
waiters on the scheduler side
    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    09ac30a View commit details
    Browse the repository at this point in the history

  2. Ensure exceptions in handlers are handled equally for sync and async

    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ecc2cc2 View commit details
    Browse the repository at this point in the history

  3. Move status running to start method to allow classes to overwrite (Mu… 

    …ltiWorker)
    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    81f9408 View commit details
    Browse the repository at this point in the history

  4. Allow server to define its own _start

    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    e831b3a View commit details
    Browse the repository at this point in the history

  5. reinstante the await self in handle_comm 

    If not awaited, the server might server handlers before the server is
properly initialized. For instance plugins and preload modules might
not be fully loaded before that happens
    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    eb4c1e8 View commit details
    Browse the repository at this point in the history

  6. Ensure Server await is always idempotent

    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    b9087cf View commit details
    Browse the repository at this point in the history

  7. factor out _start such that all subclasses must overwrite this

    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    f7d9931 View commit details
    Browse the repository at this point in the history

  8. MultiWorker brings its own await

    @fjetter
    fjetter committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    62825c2 View commit details
    Browse the repository at this point in the history