Type annotation of _reevaluate_occupancy_worker
#4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
jakirkham
force-pushed
the
opt_reev_occ_wrk
branch
5 times, most recently
from
97f2ecc to
4279b44
Compare
There is no need to retrieve this value when we already have it. So just go ahead and return the variable directly.
This way if it is `None`, we can check that and handle it much faster (both in Python and Cython/C).
Hopefully should order computation to avoid a round off error.
This should speed up mathematical operations with these variables.
jakirkham
force-pushed
the
opt_reev_occ_wrk
branch
2 times, most recently
from
bec92c2 to
49db986
Compare
|
The CI failures here appear to be unrelated, they are the same on master. |
Submitted PR ( #4405 ) to just bump the timeout. Not sure if that is acceptable or if we would rather do something else. |
|
Any other thoughts here? 🙂 |
|
Nope LGTM |
|
Thanks all! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some light type annotation of
_reevaluate_occupancy_workerto improve the Cython code generated for this function. This cuts down on the amount of time spent in this method when determining what tasks to steal.