Drop msgpack pre-0.5.2 compat code #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we require msgpack 0.6.0+, there is no need for msgpack compat code for versions prior to 0.6.0. So drop this compat code.
jakirkham
force-pushed
the
drop_old_msgpack_compat
branch
from
4cddca9 to
3885759
Compare
|
Any thoughts on this @jrbourbeau? 🙂 |
|
Planning on merging tomorrow if no comments. |
|
This seems reasonable to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we require msgpack 0.6.0+ ( #3494 ), there is no need for msgpack compat code for versions prior to 0.6.0. So drop this compat code.
cc @jrbourbeau