-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPUCurrentLoad dashboard plots #2944
Conversation
A bit of an unrelated question, but I thought you wanted to keep GPU-specific code mostly out of dask/distributed. This is just for my own understanding, what's the current policy on whether GPU code should go in here rather than dask-cuda? |
It's a good question. I could imagine moving this around later in the future. There was some non-trivial amount of work to make the dashboarding general enough to take information like this. I was also able to find a way to keep things nicely separate. I also have decent confidence that this code won't need much experimentation in the future, and will be low churn. |
For example, we defined |
Ok, makes sense. Thanks for the clarifications @mrocklin . Now going back to this PR, would you like me to test it out and review it? |
Review would be welcome |
It looks good to me, I added a couple of minor comments. I don't have experience with bokeh, superficially it looks fine for me, but maybe someone else with bokeh experience could take a look at that, otherwise, good to be merged by me. |
LGTM, looking forward to see this being used by more people! |
A first step towards fixing rapidsai/dask-cuda#36