Skip to content

Commit

Permalink
Protect graceful close from deadlocking
Browse files Browse the repository at this point in the history
  • Loading branch information
fjetter committed May 26, 2021
1 parent 7e3ec5c commit 5a71ee0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion distributed/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -3554,7 +3554,7 @@ def __init__(
"start_task_metadata": self.start_task_metadata,
"stop_task_metadata": self.stop_task_metadata,
}
shielded_handlers = {"terminate"}
shielded_handlers = {"terminate", "retire_workers"}

connection_limit = get_fileno_limit() / 2

Expand Down
1 change: 0 additions & 1 deletion distributed/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,6 @@ async def close(
if self.status in (
Status.closing,
Status.closed,
Status.closing_gracefully,
):
await self.finished()
return
Expand Down

0 comments on commit 5a71ee0

Please sign in to comment.