-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.11 build to GPU CI #11135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca. Generally this sounds good to me. There are these errors showing up in CI though
15:42:24 _________________ test_sort_values_tasks_backend[False-x-cudf] _________________
15:42:24 [gw2] linux -- Python 3.11.9 /opt/conda/envs/dask/bin/python3.11
15:42:24
15:42:24 backend = 'cudf', by = 'x', ascending = False
15:42:24
15:42:24 @pytest.mark.parametrize(
15:42:24 "backend", ["pandas", pytest.param("cudf", marks=pytest.mark.gpu)]
15:42:24 )
15:42:24 @pytest.mark.parametrize("by", ["x", "z", ["x", "z"], ["z", "x"]])
15:42:24 @pytest.mark.parametrize("ascending", [True, False])
15:42:24 def test_sort_values_tasks_backend(backend, by, ascending):
15:42:24 if backend == "cudf":
15:42:24 > pytest.importorskip("dask_cudf")
15:42:24 E pytest.PytestDeprecationWarning:
15:42:24 E Module 'dask_cudf' was found, but when imported by pytest it raised:
15:42:24 E ImportError('libarrow.so.1600: cannot open shared object file: No such file or directory')
15:42:24 E In pytest 9.1 this warning will become an error by default.
15:42:24 E You can fix the underlying problem, or alternatively overwrite this behavior and silence this warning by passing exc_type=ImportError explicitly.
15:42:24 E See [https://docs.pytest.org/en/stable/deprecations.html#pytest-importorskip-default-behavior-regarding-importerror](https://docs.pytest.org/en/stable/deprecations.html#pytest-importorskip-default-behavior-regarding-importerror%1B[0m)
15:42:24
15:42:24 dask/dataframe/tests/test_shuffle.py:1602: PytestDeprecationWarning
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 25m 32s ⏱️ + 3m 2s For more details on these failures, see this check. Results for commit ddfdd89. ± Comparison against base commit a40b35a. ♻️ This comment has been updated with latest results. |
Hoping that with #11140 resolved this should be green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca. I went ahead and merged main
here to make sure CI still passes with #11141 (it should). Will merge if CI is happy
@charlesbluca it looks like maybe there's an issue with the Python 3.11 build -- could you take a look when you get a chance? |
rerun tests |
(mild suspicions that this is some intermittent issues with Jenkins so retrying to see if this is persistent) |
@jrbourbeau looks like the stalled test runs have completed 🙂 everything look good here to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling that @charlesbluca
Contributes to rapidsai/dask-build-environment#93
pre-commit run --all-files