Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing colons in dask/dask #43

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented Oct 2, 2020

This fix updates the layout.html with changes I grabbed from
readthedocs/sphinx_rtd_theme#838 that relate to the version of the
htmlwriter that is used.

This should resolve dask/dask#6696 once a new release of the theme is
cut (I've bumped the version in __init__.py) and the update is pulled
in there.

This fix updates the `layout.html` with changes I grabbed from
readthedocs/sphinx_rtd_theme#838 that relate to the version of the
`htmlwriter` that is used.

This should resolve dask/dask#6696 once a new release of the theme is
cut (I've bumped the version in `__init__.py`) and the update is pulled
in there.
gforsyth added a commit to gforsyth/distributed that referenced this pull request Oct 2, 2020
Same fix as in dask/dask#6700

Shouldn't be merged until dask/dask-sphinx-theme#43 is merged and a
release is cut
@gforsyth
Copy link
Contributor Author

gforsyth commented Oct 2, 2020

@jacobtomlinson -- I saw your note about readthedocs/sphinx_rtd_theme#853 and so since it has been merged I've switched this back to using extends

I think the only extra bit since then is the SOCIAL GRAPH stuff, but if you have a quick second to glance over this and make sure I didn't miss something obvious, it would be greatly appreciated.

FWIW, I've built the docs locally with these changes and everything looks good.

@mrocklin
Copy link
Member

mrocklin commented Oct 2, 2020

I think that @jacobtomlinson is out for the next few weeks on parental leave. I don't think that we should wait for him as I believe that he may have turned off notifications.

Should we merge this in?

@mrocklin
Copy link
Member

mrocklin commented Oct 2, 2020

Also, I think that when we merge things are set up to automatically release

@gforsyth
Copy link
Contributor Author

gforsyth commented Oct 2, 2020

It builds fine on my end, so I think we're good to merge. (famous last words)

@mrocklin mrocklin merged commit e3e61d9 into dask:master Oct 2, 2020
@jrbourbeau
Copy link
Member

Thanks @gforsyth!

For reference, we have a GitHub actions workflow set up to automatically push to PyPI on tagged commits. I added the 1.3.3 tag over in 084b696

@gforsyth gforsyth deleted the sphinx2_compat branch October 2, 2020 20:58
@gforsyth
Copy link
Contributor Author

gforsyth commented Oct 2, 2020

Awesome, thanks @jrbourbeau !

mrocklin pushed a commit to dask/distributed that referenced this pull request Oct 6, 2020
Same fix as in dask/dask#6700

Shouldn't be merged until dask/dask-sphinx-theme#43 is merged and a
release is cut
lr4d pushed a commit to lr4d/distributed that referenced this pull request Oct 9, 2020
Same fix as in dask/dask#6700

Shouldn't be merged until dask/dask-sphinx-theme#43 is merged and a
release is cut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: args don't seem to show up properly
3 participants