-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing colons in dask/dask #43
Conversation
This fix updates the `layout.html` with changes I grabbed from readthedocs/sphinx_rtd_theme#838 that relate to the version of the `htmlwriter` that is used. This should resolve dask/dask#6696 once a new release of the theme is cut (I've bumped the version in `__init__.py`) and the update is pulled in there.
Same fix as in dask/dask#6700 Shouldn't be merged until dask/dask-sphinx-theme#43 is merged and a release is cut
@jacobtomlinson -- I saw your note about readthedocs/sphinx_rtd_theme#853 and so since it has been merged I've switched this back to using I think the only extra bit since then is the FWIW, I've built the docs locally with these changes and everything looks good. |
I think that @jacobtomlinson is out for the next few weeks on parental leave. I don't think that we should wait for him as I believe that he may have turned off notifications. Should we merge this in? |
Also, I think that when we merge things are set up to automatically release |
It builds fine on my end, so I think we're good to merge. (famous last words) |
Awesome, thanks @jrbourbeau ! |
Same fix as in dask/dask#6700 Shouldn't be merged until dask/dask-sphinx-theme#43 is merged and a release is cut
Same fix as in dask/dask#6700 Shouldn't be merged until dask/dask-sphinx-theme#43 is merged and a release is cut
This fix updates the
layout.html
with changes I grabbed fromreadthedocs/sphinx_rtd_theme#838 that relate to the version of the
htmlwriter
that is used.This should resolve dask/dask#6696 once a new release of the theme is
cut (I've bumped the version in
__init__.py
) and the update is pulledin there.