Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

warn that dask-lightgbm is deprecated #30

Merged
merged 1 commit into from
Mar 23, 2021
Merged

warn that dask-lightgbm is deprecated #30

merged 1 commit into from
Mar 23, 2021

Conversation

jameslamb
Copy link
Member

Based on my proposal in #29 (comment), I'd like to propose that dask-lightgbm have one more release, and that that release raise a warning on import informing users that the project is deprecated and that it has been merged into lightgbm.

I think this is preferable to just archiving the repo, because it means anyone upgrading dask-lightgbm in automation pip install-ing it based on a Stack Overflow answer or blog post will get a warning nudging them towards lightgbm.

As of the changes in this PR, the following warning will be shown once per session, when you import this library.

python -c "import dask_lightgbm"

/Users/jlamb/repos/dask-lightgbm/dask_lightgbm/core.py:32: UserWarning: You are using the final release of dask-lightgbm. dask-lightgbm functionality has been merged into lightgbm. Consider switching to lightgbm.

cc @jsignell @jrbourbeau

Thanks for your time and consideration.

@jsignell
Copy link
Member

Thanks for opening this @jameslamb! Are the failing tests being handled separately?

@jameslamb
Copy link
Member Author

Those same test failures look like they exist on the main branch so I don't think they're related to this PR: https://github.com/dask/dask-lightgbm/runs/1714351507

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jameslamb! I'll open a separate issue about releasing

@jrbourbeau jrbourbeau merged commit dbb66ca into dask:main Mar 23, 2021
@jameslamb jameslamb deleted the deprecation-warnings branch March 23, 2021 15:30
@jrbourbeau jrbourbeau mentioned this pull request Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants