-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support remote schedulers #72
Conversation
Rather than assume that the Scheduler is local, we now query a remote scheduler for information. This forces the `make_cluster_model` function to be asynchronous, which in turn forces many other routes to be asynchronous.
This doesn't seem to work correctly today
Then upgrade distributed to current master as of today
This may still need some things in master. I plan to release distributed next week. I'll try this again after that. |
This looks reasonable to me. I'm not sure what the issue might be with the proxy handler, but I'd be happy to look at it once the required distributed has been released. Perhaps this needs to be awaited now? https://github.com/dask/dask-labextension/pull/72/files#diff-9dd27938c6735fe022a08088466052c1R61 |
But the |
I'm also finding another workaround to this issue, so this approach may become moot. |
Supercedes dask#72 This depends on dask/distributed#2902 , which adds a `Cluster.scheduler_info` attribute to clusters which holds necessary scheduler information. We prefer this over querying a Scheduler object directly in case that scheduler is not local, as in increasingly becoming the case.
Potentially superceded by #73 (if we choose to adopt a convention internally to dask.distributed cluster managers. |
Weirdly, the |
Supercedes #72 This depends on dask/distributed#2902 , which adds a `Cluster.scheduler_info` attribute to clusters which holds necessary scheduler information. We prefer this over querying a Scheduler object directly in case that scheduler is not local, as in increasingly becoming the case.
This PR includes two major changes:
Things seem to work well for me locally, except that the dashboard proxy seems unhappy.
I'm testing with Dask's new SSHCluster, which is based on a new internal standard which everything should hopefully be based off of in the near future.
@ian-r-rose if you have time I could use your help with the proxy bits. My attempt at this was the last commit. I get errors like the following:
My guess is that Jupyter-server-proxy doesn't support async functions for
ProxyHandler.proxy
subclasses.For testing I'm using the following config file, which currently depends on a few not-yet-merged PRs in dask.distributed.