Combine CI workflows for testing and release upload to PyPI #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests to run and pass before a release is uploaded)
|
The new combined CI checks are passing, and we'll see how smoothly it performs at the next release (we should do that soon). |
|
Awesome! Thanks Genevieve 🙏 Agree it would be good to do a release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147
We want the tests to run and pass before a new release is uploaded to PyPI. This will be very useful, especially since activity on this repo is infrequent, so it's a good idea to re-run the whole test suite before releasing.
Combining the two CI workflows into the same file makes this easy, since now the PyPI upload is an optional extra step if the tests all pass and a tagged version has been created (either with
git --tag v2023.MM.DDor by making a release from the github releases page).We'll be able to see whether any of the tests fail and why in the github actions tab for this repository. It makes it much easier to create a release candidate tag, check the tests pass and it's uploaded to PyPI, then make the official release.