Add cache argument to lower_once
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
changed the title
cache argument to lower_oncelower_once
|
Any objections to this kind of change @fjetter ? We are already doing the same thing in |
This was referenced May 10, 2024
|
Opened dask-contrib/dask-sql#1332 to point to this patch to test if this unblocks the hanging tests |
fjetter
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple logic to
lower_onceso that we avoid re-lowering an expression (and its children) multiple times.Addresses the
Expr.dask/computecomponent of #1055:ddf.daskis ~200 times faster for python-only reproducer.