-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DataFrameTreeReduction is no longer part of dask #566
base: main
Are you sure you want to change the base?
Conversation
@douglasdavis @martindurant now that the legacy dask dataframe is no longer there, this causes a bunch of tests to fail as well, and forces dependency on dask-expr. |
Is the following enough for those failures:
? |
It should be. This import was removed recently and works fine for me locally
However, please make sure that |
Yes, it has been this way a long time. |
On further reading, this is no longer the same DataFrame as before at all ("DataFrame-like Expr Collection."). There is still a function, dask.dataframe.from_graph that supports making a thing, that might be what we need. What a mess! (I guess akimbo.dask is broken too) |
@lgray , let me know when you are working on this. I suppose dask-histogram is broken too; but the copy of tree-reduction should live here, so I'll wait for this PR and then fix the other. |
This class was removed from dask itself, and dask-awkward is presently broken with latest dask because of that.