Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: dev releases fails due to invalid tags #859

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Aug 5, 2024

Issue being fixed or feature implemented

Build of dev release fails due to mixing of comma- and space-separated tags in the build command.

Introduced in #854

What was done?

Use space-separated tags in build command

How Has This Been Tested?

GHA + local build

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 0a9bd64 into v1.2-dev Aug 5, 2024
4 checks passed
@lklimek lklimek deleted the fix/build-tags branch August 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants