-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace dash core quorum sign with quorum platformsign #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
changed the title
feat: replace dash core quorum sign with quorum platformsign
feat!: replace dash core quorum sign with quorum platformsign
Jul 22, 2024
shumkov
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
lklimek
added a commit
that referenced
this pull request
Jul 29, 2024
* feat!: replace dash core quorum sign with quorum platformsign (#828) * feat: replace dash core quorum sign with quorum platformsign * chore: fix Docker legacy warning * test(e2e): fix e2e quorum sign mock * build(deps): update dashd-go to v0.25.0 * build(deps): Bump bufbuild/buf-setup-action from 1.33.0 to 1.35.0 (#841) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.33.0 to 1.35.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.33.0...v1.35.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(dependabot): run dependabot on default branch, not master (#843) * chore(release): update changelog and version to 1.1.0-dev.1 (#842) * fix: address already in use (#845) * fix: address already in use * fix: always sleep * fix: active validators not always connected to each other (#844) * chore(dash): decrease log verbosity in validator conn executor * fix(node): validator conn executor not started correctly * fix: panic on full node * fix: dash dialer fails to lookup nodes in addressbook * chore(release): update changelog and version to 1.1.0-dev.2 (#846) * feat(abci): allow overriding genesis time in InitChain (#847) * chore(release): update changelog and version to 1.1.0-dev.3 (#848) * fix: validators form islands on genesis (#850) * chore(release): update changelog and version to 1.1.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
lklimek
added a commit
that referenced
this pull request
Jul 29, 2024
* feat: replace dash core quorum sign with quorum platformsign * chore: fix Docker legacy warning * test(e2e): fix e2e quorum sign mock * build(deps): update dashd-go to v0.25.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
For a more granular access control, Core introduced new endpoint
quorum platformsign
dedicated to Dash Platform ( dashpay/dash#6106 ).What was done?
Replaced
quorum sign
withquorum platformsign
.Depends on: dashpay/dashd-go#23
How Has This Been Tested?
quorumplatformsign
Breaking Changes
Requires Dash Core v21.0.0-rc.2 or newer.
Checklist:
For repository code-owners and collaborators only