Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace dash core quorum sign with quorum platformsign #828

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jul 22, 2024

Issue being fixed or feature implemented

For a more granular access control, Core introduced new endpoint quorum platformsign dedicated to Dash Platform ( dashpay/dash#6106 ).

What was done?

Replaced quorum sign with quorum platformsign.

Depends on: dashpay/dashd-go#23

How Has This Been Tested?

  1. Started Dash Platform with Core configured to whitelist quorumplatformsign
  2. Ensured that new votes can be signed by affected node
  3. Removed quorumplatformsign from Core whitelist
  4. Restarted Core
  5. Checked that we cannot Tenderdash cannot sign votes: signerEndpoint returned error # 500: cannot sign vote: status code: 403
  6. Reverted config
  7. Ensured new votes can be signed again

Breaking Changes

Requires Dash Core v21.0.0-rc.2 or newer.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title feat: replace dash core quorum sign with quorum platformsign feat!: replace dash core quorum sign with quorum platformsign Jul 22, 2024
@lklimek lklimek added this to the v1.1 milestone Jul 22, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 7af709a into v1.1-dev Jul 23, 2024
15 checks passed
@lklimek lklimek deleted the feat/use-dash-core-quorum-platformsign branch July 23, 2024 08:49
lklimek added a commit that referenced this pull request Jul 29, 2024
* feat!: replace dash core quorum sign with quorum platformsign (#828)

* feat: replace  dash core quorum sign with quorum platformsign

* chore: fix Docker legacy warning

* test(e2e): fix e2e quorum sign mock

* build(deps): update dashd-go to v0.25.0

* build(deps): Bump bufbuild/buf-setup-action from 1.33.0 to 1.35.0 (#841)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.33.0 to 1.35.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.33.0...v1.35.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(dependabot): run dependabot on default branch, not master (#843)

* chore(release): update changelog and version to 1.1.0-dev.1 (#842)

* fix: address already in use (#845)

* fix: address already in use

* fix: always sleep

* fix: active validators not always connected to each other (#844)

* chore(dash): decrease log verbosity in validator conn executor

* fix(node): validator conn executor not started correctly

* fix: panic on full node

* fix: dash dialer fails to lookup nodes in addressbook

* chore(release): update changelog and version to 1.1.0-dev.2 (#846)

* feat(abci): allow overriding genesis time in InitChain (#847)

* chore(release): update changelog and version to 1.1.0-dev.3 (#848)

* fix: validators form islands on genesis (#850)

* chore(release): update changelog and version to 1.1.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
lklimek added a commit that referenced this pull request Jul 29, 2024
* feat: replace  dash core quorum sign with quorum platformsign

* chore: fix Docker legacy warning

* test(e2e): fix e2e quorum sign mock

* build(deps): update dashd-go to v0.25.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants