feat(dashmate): allow configuring zmq using dashmate #2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Dashmate
participant Docker
participant Core Service
participant DAPI
User->>Dashmate: Configure core.zmq.host/port
Dashmate->>Docker: Update docker-compose with ZMQ port mapping
Docker->>Core Service: Start with ZMQ host/port env vars
Core Service-->>DAPI: Provide ZMQ notifications via configured port
User->>Dashmate: Run multi-node setup
Dashmate->>Dashmate: Increment ZMQ port per node
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ gRPC Query Coverage Report |
chore(dashmate): config migrations fix(dashmate): multi-node zmq ports setup chore: allow disabling zmq chore: restore zmq config for dapi chore: remove zmq.enabled
lklimek
force-pushed
the
feat/dashmate-zmq
branch
from
7f63984 to
fd3476b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring Dash Core’s ZeroMQ (ZMQ) interface via a new core.zmq configuration section. It updates templates, defaults, migrations, schema, tasks, Docker mappings, and documentation to expose host and port settings for ZMQ.
- Introduce
core.zmqin base defaults and JSON schema - Propagate ZMQ port offset in local cluster setup and config migrations
- Update
dash.conftemplate, Docker Compose, and docs to use configurable ZMQ host/port
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dashmate/templates/core/dash.conf.dot | Use it.core.zmq.port instead of hard-coded port |
| packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js | Offset core.zmq.port per node |
| packages/dashmate/src/config/configJsonSchema.js | Add JSON schema for core.zmq and make it required |
| packages/dashmate/configs/defaults/getBaseConfigFactory.js | Set default core.zmq.host and core.zmq.port |
| packages/dashmate/configs/getConfigFileMigrationsFactory.js | Add migration to inject core.zmq into existing configs |
| packages/dashmate/docker-compose.yml | Map ${CORE_ZMQ_HOST}:${CORE_ZMQ_PORT} for Core |
| packages/dashmate/docs/services/index.md | Document configurable ZMQ exposure |
| packages/dashmate/docs/services/core.md | Add ZMQ row to Core service table |
| packages/dashmate/docs/config/core.md | Document core.zmq options |
Comments suppressed due to low confidence (1)
packages/dashmate/templates/core/dash.conf.dot:73
- The ZMQ notification lines are missing their leading '-' prefix, so they won't be recognized as command-line flags in dash.conf. Add a '-' before each
zmqpub*entry, for example-zmqpubrawtx=....
zmqpubrawtx=tcp://0.0.0.0:{{=it.core.zmq.port}}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/dashmate/docs/config/core.md (1)
70-90: Comprehensive ZMQ documentation with minor style fix needed.The documentation thoroughly covers the ZMQ configuration, including security considerations and usage examples.
Apply this diff to fix the markdown list style as flagged by the linter:
-- ZMQ provides low-latency notifications for blocks, transactions, and other blockchain events -- **host**: Controls Docker port exposure: - - `127.0.0.1`: ZMQ port exposed only on localhost (local machine access) - - `0.0.0.0`: ZMQ port exposed on all interfaces (public internet access - use with caution) -- **port**: The port number for ZMQ notifications -- DAPI uses ZMQ to receive real-time blockchain data for streaming to clients -- ZMQ notifications include raw transactions, blocks, instantlocks, and chainlocks -- ZMQ is always enabled in Dash Core as it's used by internal components +* ZMQ provides low-latency notifications for blocks, transactions, and other blockchain events +* **host**: Controls Docker port exposure: + * `127.0.0.1`: ZMQ port exposed only on localhost (local machine access) + * `0.0.0.0`: ZMQ port exposed on all interfaces (public internet access - use with caution) +* **port**: The port number for ZMQ notifications +* DAPI uses ZMQ to receive real-time blockchain data for streaming to clients +* ZMQ notifications include raw transactions, blocks, instantlocks, and chainlocks +* ZMQ is always enabled in Dash Core as it's used by internal components -**Security Note**: Be cautious when setting `host` to `0.0.0.0` as it makes ZMQ publicly accessible. +**Security Note**: Be cautious when setting `host` to `0.0.0.0` as it makes ZMQ publicly accessible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
packages/dashmate/templates/core/dash.conf.dotis excluded by!**/*.dot
📒 Files selected for processing (8)
packages/dashmate/configs/defaults/getBaseConfigFactory.js(1 hunks)packages/dashmate/configs/getConfigFileMigrationsFactory.js(1 hunks)packages/dashmate/docker-compose.yml(3 hunks)packages/dashmate/docs/config/core.md(1 hunks)packages/dashmate/docs/services/core.md(1 hunks)packages/dashmate/docs/services/index.md(1 hunks)packages/dashmate/src/config/configJsonSchema.js(2 hunks)packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.{js,ts,tsx}`: Lint JavaScript/TypeScript code using `yarn lint`
**/*.{js,ts,tsx}: Lint JavaScript/TypeScript code usingyarn lint
📄 Source: CodeRabbit Inference Engine (CLAUDE.md)
List of files the instruction was applied to:
packages/dashmate/configs/defaults/getBaseConfigFactory.jspackages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.jspackages/dashmate/src/config/configJsonSchema.jspackages/dashmate/configs/getConfigFileMigrationsFactory.js
🧠 Learnings (9)
📓 Common learnings
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: CR
PR: dashpay/platform#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-01T13:35:47.879Z
Learning: Manage the local development environment using Docker Compose and dashmate
packages/dashmate/configs/defaults/getBaseConfigFactory.js (3)
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2107
File: packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js:116-124
Timestamp: 2024-11-22T10:28:33.588Z
Learning: In `configureCoreTaskFactory` in `packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js`, the `local_seed` configuration is already established earlier in the code, so adding error handling for its absence in the 'Generating funds to use as a collateral for masternodes' task is unnecessary.
packages/dashmate/docker-compose.yml (7)
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: CR
PR: dashpay/platform#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-01T13:35:47.879Z
Learning: Manage the local development environment using Docker Compose and dashmate
Learnt from: shumkov
PR: dashpay/platform#2255
File: packages/dashmate/src/status/scopes/platform.js:112-116
Timestamp: 2024-10-19T06:10:00.808Z
Learning: In the Dashmate project, when fetching from Tenderdash RPC endpoints like `/status`, `/net_info`, and `/abci_info`, if one request fails, it's likely that the others will fail as well, so individual error handling for each fetch may not be necessary.
Learnt from: lklimek
PR: dashpay/platform#2318
File: .github/workflows/tests-build-image.yml:45-45
Timestamp: 2024-11-13T10:31:30.891Z
Learning: In the dashpay/platform repository, changes to `.github/workflows/tests-build-image.yml` that switch the Docker image platform from `linux/arm64` to `linux/amd64` for testing purposes are acceptable when required to run on GitHub-hosted runners. ARM64 testing is covered on the testnet.
Learnt from: QuantumExplorer
PR: dashpay/platform#2690
File: packages/wasm-sdk/src/queries/document.rs:383-384
Timestamp: 2025-07-10T00:37:09.565Z
Learning: In the Dash platform, DPNS (Dash Platform Name Service) contracts have the same ID across all networks (mainnet, testnet, etc.), so hardcoding the DPNS contract ID is appropriate and doesn't need to be configurable.
Learnt from: shumkov
PR: dashpay/platform#2270
File: packages/dapi/lib/externalApis/tenderdash/requestTenderRpc.js:33-37
Timestamp: 2024-10-24T04:57:23.753Z
Learning: JSON-RPC errors from Tenderdash can have the same error code even when the error messages are different.
packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js (10)
Learnt from: shumkov
PR: dashpay/platform#2107
File: packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js:116-124
Timestamp: 2024-11-22T10:28:33.588Z
Learning: In `configureCoreTaskFactory` in `packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js`, the `local_seed` configuration is already established earlier in the code, so adding error handling for its absence in the 'Generating funds to use as a collateral for masternodes' task is unnecessary.
Learnt from: shumkov
PR: dashpay/platform#2298
File: packages/dashmate/src/commands/ssl/cleanup.js:33-50
Timestamp: 2024-10-31T15:37:28.986Z
Learning: In `packages/dashmate/src/commands/ssl/cleanup.js`, the `cleanupZeroSSLCertificatesTask` function already includes progress reporting within its nested `Listr` tasks, so additional progress reporting in the `CleanupCommand` is unnecessary.
Learnt from: shumkov
PR: dashpay/platform#2297
File: packages/dashmate/src/listr/tasks/ssl/zerossl/obtainZeroSSLCertificateTaskFactory.js:148-150
Timestamp: 2024-10-31T14:41:42.158Z
Learning: In the `obtainZeroSSLCertificateTaskFactory` function in `packages/dashmate/src/listr/tasks/ssl/zerossl/obtainZeroSSLCertificateTaskFactory.js`, the application already fails appropriately if `configFileRepository.write(configFile)` fails, so additional error handling around this operation is unnecessary.
Learnt from: shumkov
PR: dashpay/platform#2298
File: packages/dashmate/src/listr/tasks/ssl/zerossl/cleanupZeroSSLCertificatesTaskFactory.js:74-74
Timestamp: 2024-10-31T15:54:57.897Z
Learning: In the `cleanupZeroSSLCertificatesTask` function located in `packages/dashmate/src/listr/tasks/ssl/zerossl/cleanupZeroSSLCertificatesTaskFactory.js`, the team prefers to include a small fixed delay between all requests to avoid overloading ZeroSSL, rather than implementing exponential backoff.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2270
File: packages/dapi/lib/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js:19-19
Timestamp: 2024-10-24T04:58:02.843Z
Learning: For operations involving Tenderdash where no client library exists yet, it's acceptable to use the Node.js built-in `crypto` module.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/dashmate/configs/defaults/getTestnetConfigFactory.js:113-117
Timestamp: 2024-10-04T09:09:05.090Z
Learning: In the Tenderdash genesis file, the `app_version` must be static because it's immutable.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/dashmate/configs/defaults/getTestnetConfigFactory.js:113-117
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the Tenderdash genesis file, the `app_version` must be static because it's immutable.
Learnt from: shumkov
PR: dashpay/platform#2270
File: packages/dapi/lib/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js:75-77
Timestamp: 2024-10-24T04:59:20.436Z
Learning: Tenderdash's `tx` RPC method accepts transaction hashes in base64 encoding, or in hex encoding if prefixed with `0x`. Therefore, in `packages/dapi/lib/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js`, it's acceptable to use `stHash.toString('base64')` when calling `requestTenderRpc('tx', { hash: stHash.toString('base64') })`.
packages/dashmate/docs/services/index.md (3)
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: QuantumExplorer
PR: dashpay/platform#2690
File: packages/wasm-sdk/src/queries/document.rs:383-384
Timestamp: 2025-07-10T00:37:09.565Z
Learning: In the Dash platform, DPNS (Dash Platform Name Service) contracts have the same ID across all networks (mainnet, testnet, etc.), so hardcoding the DPNS contract ID is appropriate and doesn't need to be configurable.
packages/dashmate/docs/services/core.md (4)
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: CR
PR: dashpay/platform#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-01T13:35:47.879Z
Learning: Manage the local development environment using Docker Compose and dashmate
Learnt from: QuantumExplorer
PR: dashpay/platform#2690
File: packages/wasm-sdk/src/queries/document.rs:383-384
Timestamp: 2025-07-10T00:37:09.565Z
Learning: In the Dash platform, DPNS (Dash Platform Name Service) contracts have the same ID across all networks (mainnet, testnet, etc.), so hardcoding the DPNS contract ID is appropriate and doesn't need to be configurable.
packages/dashmate/src/config/configJsonSchema.js (3)
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2345
File: packages/wallet-utils-contract/schema/v1/wallet-utils-contract-documents.json:49-55
Timestamp: 2024-11-25T07:49:05.419Z
Learning: In the schema definitions for the `wallet-utils-contract` (file `packages/wallet-utils-contract/schema/v1/wallet-utils-contract-documents.json`), the `$createdAt` field is a system field augmented by DPP and does not need to be defined explicitly in the schema's properties.
packages/dashmate/configs/getConfigFileMigrationsFactory.js (4)
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2107
File: packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js:116-124
Timestamp: 2024-11-22T10:28:33.588Z
Learning: In `configureCoreTaskFactory` in `packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js`, the `local_seed` configuration is already established earlier in the code, so adding error handling for its absence in the 'Generating funds to use as a collateral for masternodes' task is unnecessary.
Learnt from: shumkov
PR: dashpay/platform#2297
File: packages/dashmate/src/listr/tasks/ssl/zerossl/obtainZeroSSLCertificateTaskFactory.js:148-150
Timestamp: 2024-10-31T14:41:42.158Z
Learning: In the `obtainZeroSSLCertificateTaskFactory` function in `packages/dashmate/src/listr/tasks/ssl/zerossl/obtainZeroSSLCertificateTaskFactory.js`, the application already fails appropriately if `configFileRepository.write(configFile)` fails, so additional error handling around this operation is unnecessary.
packages/dashmate/docs/config/core.md (2)
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-04T09:08:48.470Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
Learnt from: shumkov
PR: dashpay/platform#2206
File: packages/rs-platform-version/src/version/protocol_version.rs:155-157
Timestamp: 2024-10-09T00:22:57.778Z
Learning: In the dashmate default configurations, the default protocol version for local networks has been removed, and an update mechanism for the protocol version in the consensus parameters has been implemented.
🪛 markdownlint-cli2 (0.17.2)
packages/dashmate/docs/config/core.md
83-83: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
84-84: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
90-90: Unordered list style
Expected: asterisk; Actual: dash
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
- GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
- GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
- GitHub Check: Build JS packages / Build JS
🔇 Additional comments (10)
packages/dashmate/configs/defaults/getBaseConfigFactory.js (1)
108-111: LGTM! Well-integrated ZMQ configuration.The ZMQ configuration follows the established pattern for core service configurations and uses appropriate default values (localhost binding with non-conflicting port 29998).
packages/dashmate/src/listr/tasks/setup/setupLocalPresetTaskFactory.js (2)
6-6: Import reordering looks good.The reordering of imports doesn't affect functionality and maintains alphabetical organization.
127-127: Excellent port increment implementation.The ZMQ port increment follows the same pattern as other ports (P2P and RPC), ensuring no port conflicts in multi-node local environments.
packages/dashmate/docs/services/core.md (1)
36-36: Accurate documentation update.The ZMQ port documentation correctly reflects the configuration values and follows the established table format. The config paths and default values match the implementation.
packages/dashmate/src/config/configJsonSchema.js (2)
310-322: Well-structured schema definition.The ZMQ schema correctly references the host and port definitions, enforces required fields, and follows the same pattern as other core configurations.
491-491: Proper schema requirement integration.Adding 'zmq' to the required array ensures the configuration is validated consistently with other core components.
packages/dashmate/configs/getConfigFileMigrationsFactory.js (1)
1099-1108: LGTM! Migration logic is correct and consistent.The migration properly adds the new
core.zmqconfiguration to existing configs that lack it, following the established pattern of other migrations in this file.packages/dashmate/docker-compose.yml (2)
39-39: Excellent! ZMQ port exposure is now configurable.The addition of the ZMQ port mapping using environment variables maintains consistency with other configurable ports in the docker-compose setup.
150-150: Good consistency improvement.Replacing the hardcoded ZMQ port with the environment variable ensures all services use the same configurable port value.
Also applies to: 182-182
packages/dashmate/docs/services/index.md (1)
76-86: Excellent clarification of ZMQ port configuration.The updated documentation correctly classifies the ZMQ port as configurable and provides clear guidance on the available configuration options, resolving the previous inconsistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
To use dash-evo-tool with a local network, we need to expose zeromq.
What was done?
Added config option
core.zmqto control how zeromq is exposed.How Has This Been Tested?
GHA
Breaking Changes
New config is needed, but migrations are done.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
hostandport) to the Core service configuration, allowing customization of real-time blockchain event notifications.Bug Fixes
Documentation