fix(drive): security vulnerability in hashbrown

[shumkov]

Issue being fixed or feature implemented

Rust audit is failing:

{"found":true,"count":1,"list":[{"advisory":{"id":"RUSTSEC-2024-0402","package":"hashbrown","title":"Borsh serialization of HashMap is non-canonical","description":"The borsh serialization of the HashMap did not follow the borsh specification.\nIt potentially produced non-canonical encodings dependent on insertion order.\nIt also did not perform canonicty checks on decoding.\n\nThis can result in consensus splits and cause equivalent objects to be\nconsidered distinct.\n\nThis was patched in 0.15.1.","date":"2024-10-11","aliases":[],"related":[],"collection":"crates","categories":[],"keywords":["borsh"],"cvss":null,"informational":null,"references":[],"source":null,"url":"https://github.com/rust-lang/hashbrown/issues/576","withdrawn":null,"license":"CC0-1.0"},"versions":{"patched":[">=0.15.1"],"unaffected":["<=0.14"]},"affected":{"arch":[],"os":[],"functions":{"hashbrown::HashMap::borsh_serialize":["=0.15.0"]}},"package":{"name":"hashbrown","version":"0.14.5","source":"registry+https://github.com/rust-lang/crates.io-index","checksum":"e5274423e17b7c9fc20b6e7e208532f9b19825d82dfd615708b70edd83df41f1","dependencies":[{"name":"ahash","version":"0.8.11","source":"registry+https://github.com/rust-lang/crates.io-index"}],"replace":null}}]}

What was done?

• Updated metrics and metrics-exporter-prometheus crates

How Has This Been Tested?

With CI

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Chores
  • Updated the version of the metrics dependency to enhance performance.
  • Upgraded the metrics-exporter-prometheus dependency for improved functionality.

[coderabbitai]

Walkthrough

The pull request modifies the Cargo.toml file for the drive-abci package, focusing on updating the versions of existing dependencies. The metrics dependency has been upgraded from version 0.23 to 0.24, and the metrics-exporter-prometheus dependency has been updated from version 0.15 to 0.16. The features associated with the metrics-exporter-prometheus dependency remain unchanged.

Changes

File Path	Change Summary
packages/rs-drive-abci/Cargo.toml	Updated metrics from 0.23 to 0.24 and metrics-exporter-prometheus from 0.15 to 0.16. Features for metrics-exporter-prometheus unchanged.

Possibly related PRs

• chore: update to latest rust dash core with x11 optional #2251: This PR updates the Cargo.toml file for the drive-abci package, which is directly related to the main PR's changes in the same file, specifically regarding dependency updates.
• fix(drive): uncommitted state if db transaction fails #2305: This PR modifies the packages/rs-drive-abci/src/abci/handler/finalize_block.rs and other files in the rs-drive-abci package, which is relevant as it deals with the functionality of the drive, potentially interacting with the updated dependencies in the main PR.
• fix(dashmate): failing doctor with drive metrics enabled #2348: This PR involves changes to the metrics configuration for the drive-abci service, which relates to the updated metrics-exporter-prometheus dependency in the main PR.

Suggested reviewers

• QuantumExplorer

🐇 In the meadow, hops a rabbit bright,
With updates to metrics, oh what a sight!
Dependencies fresh, they spring and they play,
In the world of code, they dance and sway.
From 0.23 to 0.24,
A leap for the drive, let’s code some more! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5c9b3fc and 5eb6473.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• packages/rs-drive-abci/Cargo.toml (1 hunks)

🔇 Additional comments (2)

packages/rs-drive-abci/Cargo.toml (2)

61-63: Verify if these updates address the hashbrown vulnerability

While the PR aims to fix the hashbrown security vulnerability (RUSTSEC-2024-0402), it's not immediately clear if updating these metrics-related crates effectively addresses the issue. Let's verify the dependency chain and versions.

---

61-63: Verify impact on Borsh serialization

Since the vulnerability affects Borsh serialization of HashMaps, we should verify where HashMap serialization is used in the codebase.