Confidential Transactions #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
reviewed
Nov 8, 2024
|
@UdjinM6 @PastaPastaPasta I believe recent updates to the DIP have addressed all your review comments, so I am requesting another review |
|
also, it was not mentioned in review but since this DIP changes Consensus rules I changed the DIP Type to Consensus |
| * A BP rangeproof that ensures the amount transferred is inside a certain interval between 0 and 2^N - 1 | ||
| * To support all potential value transfers between 0 and 21M the BP rangeproof needs N equal to 52 | ||
| * The exact size of the proof depends on the number of inputs and outputs | ||
| * An explicit fee, since the fee cannot be computed by the network since the amount is hidden |
There was a problem hiding this comment.
I don't see where this explicit fee is in your specified format
dip-ct.md
Outdated
Comment on lines
88
to
91
| The exact structure of a CT address is as follows. It contains the following data: | ||
|
|
||
| * salt (AKA blinding factor) . 32 byte random value | ||
| * pk . The compressed public key, a 33 byte secp256k1 curve point. |
There was a problem hiding this comment.
Normally, to spend from an address you expose the public key. Here you would need to expose the pk and salt in order to spend? what is the point of the salt?
thephez
reviewed
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft DIP for adding Confidential Transactions (CTs) to Dash. I would like to request a DIP number be assigned.
Any and all feedback is welcome, including suggestions for a base58 prefix for CT addresses.