Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crowdnode): v20 APY calculation #639

Merged
merged 21 commits into from
Jan 25, 2024
Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jan 23, 2024

Issue being fixed or feature implemented

Some fixes are needed for CrowdNode APY calculation with v20.

What was done?

  • Use virtual MN count (HPMN are counted as 4)
  • Change treasuryPart to 20%
  • Migrate CrowdNodeAPYView to Swift
  • Recheck APY after the blockchain is synced

How Has This Been Tested?

QA (some existing issues found), manually

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf January 23, 2024 11:57
@Syn-McJ Syn-McJ self-assigned this Jan 23, 2024
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit e8b519b into dashpay:develop Jan 25, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the fix/crowdnode-apy branch January 25, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants