Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UI fixes and improvements for iOS 15 #580

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix: UI fixes and improvements for iOS 15 #580

merged 2 commits into from
Jul 27, 2023

Conversation

tikhop
Copy link
Collaborator

@tikhop tikhop commented Jul 26, 2023

Issue being fixed or feature implemented

UI fixes and improvements for iOS 15

What was done?

  • Properly wrap the text from clipboard on iOS 15
  • Properly present confirmation screen on iOS 15
  • Align payment flow with Android

How Has This Been Tested?

QA/Manually

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@tikhop tikhop requested review from pankcuf and Syn-McJ July 26, 2023 18:36
@tikhop tikhop marked this pull request as ready for review July 26, 2023 18:37
Syn-McJ
Syn-McJ approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tikhop tikhop merged commit 6d727fa into develop Jul 27, 2023
@Syn-McJ Syn-McJ deleted the fix/sheet-controller branch November 7, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

@pankcuf pankcuf Awaiting requested review from pankcuf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikhop @Syn-McJ