Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce timeout #45

Merged
merged 6 commits into from
Jun 30, 2022
Merged

feat: introduce timeout #45

merged 6 commits into from
Jun 30, 2022

Conversation

strophy
Copy link
Contributor

@strophy strophy commented Jun 22, 2022

This PR is based on #22 and also adds a function to specify the timeout after creating the RPC client. I need help understanding how callbacks are supposed to work inside promises, and how to test this function properly.

lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
@shumkov shumkov changed the title chore: handle timeouts feat: introduce timeout Jun 23, 2022
lib/index.js Outdated Show resolved Hide resolved
lib/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@nmarley nmarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants