Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evo)!: quorum verify fails due to wrong order of args #29

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

lklimek
Copy link

@lklimek lklimek commented Jan 13, 2025

Quorum Verify call fails due to invalid order of arguments and invalid return type.

What was done

  • fixed order of arguments
  • fixed parsing of quorum verify response
  • updated tests, added one new test

How it was tested

@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12867373495

Details

  • 9 of 21 (42.86%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 48.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/evo.go 0 5 0.0%
btcjson/dashevoresults.go 7 14 50.0%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 80.95%
database/ffldb/blockio.go 4 92.62%
Totals Coverage Status
Change from base Build 12391985871: -0.01%
Covered Lines: 23626
Relevant Lines: 48290

💛 - Coveralls

@lklimek lklimek changed the title fix(evo): quorum verify fails due to wrong order of args fix(evo)!: quorum verify fails due to wrong order of args Jan 20, 2025
@lklimek lklimek self-assigned this Jan 20, 2025
@lklimek lklimek requested a review from shumkov January 20, 2025 13:56
@lklimek lklimek merged commit 799c242 into master Jan 21, 2025
3 checks passed
@lklimek lklimek deleted the fix/quorum-verify branch January 21, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants