Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: actually use masternode with basic bls pubkey in mnauth test #6481

Merged
merged 3 commits into from
Dec 14, 2024
Merged

test: actually use masternode with basic bls pubkey in mnauth test #6481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db20e3
test: actually use masternode with basic bls pubkey in mnauth test
UdjinM6 Dec 11, 2024
6519856
test: don't add legacy bls mn on start
UdjinM6 Dec 12, 2024
ec00c37
test: fix off-by-one in dynamically_add_masternode
UdjinM6 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/functional/rpc_mnauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@

class FakeMNAUTHTest(DashTestFramework):
def set_test_params(self):
self.set_dash_test_params(2, 1)
self.set_dash_test_params(1, 0)

def run_test(self):
self.activate_v19(expected_activation_height=900)
self.dynamically_add_masternode()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we don't need 2 of them:

-self.set_dash_test_params(2, 1)
+self.set_dash_test_params(1, 0)


masternode = self.mninfo[0]
masternode.node.add_p2p_connection(P2PInterface())
Expand Down
2 changes: 1 addition & 1 deletion test/functional/test_framework/test_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ def dynamically_add_masternode(self, evo=False, rnd=None, should_be_rejected=Fal
return

self.dynamically_initialize_datadir(node_p2p_port, node_rpc_port)
node_info = self.add_dynamically_node(self.extra_args[1])
node_info = self.add_dynamically_node(self.extra_args[0])

args = ['-masternodeblsprivkey=%s' % created_mn_info.keyOperator] + node_info.extra_args
self.start_node(mn_idx, args)
Expand Down
Loading