Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qt): improve GUI responsiveness for huge wallets #6457

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 6, 2024

Issue being fixed or feature implemented

Somehow a 500k+ txes wallet is MUCH more responsive with this patch. I'm not sure if it's macos only or not though, pls test.

What was done?

How Has This Been Tested?

Run a wallet with 100k+ txes in it and send a tx or try changing units.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 22.1 milestone Dec 6, 2024
@UdjinM6 UdjinM6 changed the title fix(qt): emit dataChanged for the whole model in TransactionTableModel fix(qt): improve GUI responsiveness for huge wallets Dec 6, 2024
@knst
Copy link
Collaborator

knst commented Dec 7, 2024

@UdjinM6 is everything right with columns width for you?

image

maybe unrelated bug on develop, but I just noticed it.

UPD: I found a reason, not sure how to fix it, but that's unrelated to this PR. My fonts in system is setup to resolution 144 dpi, it causes this bug. As I tested, 90dpi and 120dpi are completely fine. If I set 144 or 160 dpi - it doesn't fit any UI elements anymore.

Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a4378fc

it works much faster for faucet wallet when new transaction is coming or if change in settings 'amount' format

@UdjinM6
Copy link
Author

UdjinM6 commented Dec 7, 2024

@UdjinM6 is everything right with columns width for you?

maybe unrelated bug on develop, but I just noticed it.

I don't have this issue on macOS. What OS are you using?

... if change in settings 'amount' format

You can change it without going into setting btw, can simply click unit name in the bottom left corner.

Screenshot 2024-12-07 at 10 41 46

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a4378fc

I did use it, didn't strictly notice any massive gains, but was focusing more on the testing I was doing at the time, I think I noticed improvements, but no regressions noticed

@PastaPastaPasta PastaPastaPasta merged commit babafbb into dashpay:develop Dec 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants