Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pass CWallet reference to CTransactionBuilder #6449

Merged
merged 1 commit into from
Dec 10, 2024
Merged

refactor: pass CWallet reference to CTransactionBuilder #6449

merged 1 commit into from
Dec 10, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Dec 3, 2024 •
edited
Loading

Issue being fixed or feature implemented

Follow-up for #6441

What was done?

Pass reference to CWallet instead const reference to smart pointer with CWallet to CTransactionBuilder.

How Has This Been Tested?

Run unit/functional tests

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 22.1 milestone Dec 3, 2024
@knst knst force-pushed the refactor-ctransactionbuilder branch from d7daf4d to 43778b0 Compare December 3, 2024 18:00
UdjinM6
UdjinM6 approved these changes Dec 5, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 43778b0

PastaPastaPasta
PastaPastaPasta approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 43778b0

@PastaPastaPasta PastaPastaPasta merged commit e482d18 into dashpay:develop Dec 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.1
Development

Successfully merging this pull request may close these issues.
3 participants
@knst @UdjinM6 @PastaPastaPasta