Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: a bunch of trivial-ish headers improvements #6376

Merged
merged 3 commits into from
Nov 12, 2024
Merged

refactor: a bunch of trivial-ish headers improvements #6376

merged 3 commits into from
Nov 12, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Oct 31, 2024 •
edited
Loading

Issue being fixed or feature implemented

Split from #6375 and added some extra

What was done?

Tidy up headers of evo/ and llmq/:

  • removed unused includes and added missing
  • removed unused forward declarations and added missing
  • removed helper GetCoinbaseTx, moved helper IsQuorumDKGEnabled from header to implementation

How Has This Been Tested?

Run unit and functional tests

Compilation time in theory should be improved, in really it shaved just 2-5 seconds from 5 minutes by my benchmark.

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@knst knst mentioned this pull request Oct 31, 2024
Merged
5 tasks
@knst knst force-pushed the refactor-remove-GetTxPayload branch from d99c14a to 047309f Compare November 4, 2024 08:14
@knst knst changed the title refactor: remove helper GetTxPayload which is used only in one function refactor: a bunch of trivial-ish headers improvements Nov 4, 2024
@knst knst added this to the 22 milestone Nov 4, 2024
@knst knst force-pushed the refactor-remove-GetTxPayload branch 3 times, most recently from 2e73031 to 0c023f0 Compare November 4, 2024 13:03
@knst knst marked this pull request as ready for review November 4, 2024 13:30
UdjinM6
UdjinM6 reviewed Nov 4, 2024
View reviewed changes
src/evo/cbtx.cpp Show resolved Hide resolved
src/evo/assetlocktx.h Outdated Show resolved Hide resolved
@knst knst force-pushed the refactor-remove-GetTxPayload branch from 0c023f0 to e9387ee Compare November 11, 2024 07:42
UdjinM6
UdjinM6 approved these changes Nov 11, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e9387ee

PastaPastaPasta
PastaPastaPasta approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e9387ee

@PastaPastaPasta PastaPastaPasta merged commit 3aa51d6 into dashpay:develop Nov 12, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22
Development

Successfully merging this pull request may close these issues.
3 participants
@knst @UdjinM6 @PastaPastaPasta