fix: ignore triggers from the past when voting

[UdjinM6]

Issue being fixed or feature implemented

we should not vote on triggers from the past

What was done?

How Has This Been Tested?

n/a

Breaking Changes

n/a

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[PastaPastaPasta]

utACK for squash merge; are there any ideas on how we can create a test for this?

[knst]

there any ideas on how we can create a test for this?

Functional tests have a feature "check a string in logs". So, we can make some triggers to expire; after that assert that logs doesn't have this substring: CGovernanceManager::%s Voting NO-FUNDING - it appears in logs only if trigger is not expired with current implementation.

This feature assert_debug_log is used here and here for example

[knst]

p.s. assert_debug_log can works in 2 modes: expected logs and unexpected logs; both arguments are arrays.
Here's a signature:

    def assert_debug_log(self, expected_msgs, unexpected_msgs=None, timeout=2):

[UdjinM6]

there any ideas on how we can create a test for this?

Functional tests have a feature "check a string in logs". So, we can make some triggers to expire; after that assert that logs doesn't have this substring: CGovernanceManager::%s Voting NO-FUNDING - it appears in logs only if trigger is not expired with current implementation.

This feature assert_debug_log is used here and here for example

Good idea! 👍

[PastaPastaPasta]

utACK for squash merge

[knst]

utACK