Tests: Fix the way nodes are connected to each other in setup_network/start_masternodes #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Masternodes should take care of intra-quorum connections themselves
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 6, 2019
…/start_masternodes (dashpay#3221) * Tests: Connect to the control node only in start_masternodes Masternodes should take care of intra-quorum connections themselves * Reconnect non-masternodes back to the control node
MIPPL
pushed a commit
to biblepay/biblepay
that referenced
this pull request
Jan 1, 2020
…ttack vector) * commit '2ae1ce4800a22c717b67aea97680bbe1eeffa07b': [v0.14.0.x] Update release notes with notable changes and changelog (dashpay#3229) [v0.14.0.x] Make sure mempool txes are properly processed by CChainLocksHandler despite node restarts (dashpay#3230) [v0.14.0.x] Bump version and prepare release notes (dashpay#3228) More fixes in llmq-is-retroactive tests Make llmq-is-retroactive test compatible with 0.14.0.x Make wait_for_xxx methods compatible with 0.14.0.x Allow re-signing of IS locks when performing retroactive signing (dashpay#3219) Add wait_for_xxx methods as found in develop More/better logging for InstantSend Tests: Fix the way nodes are connected to each other in setup_network/start_masternodes (dashpay#3221) More fixes related to extra_args Tests: Allow specifying different cmd-line params for each masternode (dashpay#3222) Don't join thread in CQuorum::~CQuorum when called from within the thread (dashpay#3223) Merge bitcoin#12392: Fix ignoring tx data requests when fPauseSend is set on a peer (dashpay#3225) # Conflicts: # configure.ac # doc/man/biblepay-cli.1 # doc/man/biblepay-qt.1 # doc/man/biblepay-tx.1 # doc/man/biblepayd.1 # doc/release-notes.md # qa/pull-tester/rpc-tests.py # qa/rpc-tests/test_framework/test_framework.py # src/clientversion.h
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
…/start_masternodes (dashpay#3221) * Tests: Connect to the control node only in start_masternodes Masternodes should take care of intra-quorum connections themselves * Reconnect non-masternodes back to the control node
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
…/start_masternodes (dashpay#3221) * Tests: Connect to the control node only in start_masternodes Masternodes should take care of intra-quorum connections themselves * Reconnect non-masternodes back to the control node Signed-off-by: cevap <dev@i2pmail.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masternodes should take care of intra-quorum connections themselves. Have to take care of non-masternode/"simple" nodes manually though.
(backport candidate because of #3219 being a backport candidate too)