Backport wallet-dump.py and key timestamp PRs #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
changed the title
UdjinM6
approved these changes
Jan 31, 2018
qa/rpc-tests/wallet-dump.py
Outdated
| assert_equal(found_addr, test_addr_count) | ||
| # TODO clarify if we want the behavior that is tested below in Dash (only when HD seed was generated and not user-provided) | ||
| # assert_equal(found_addr_chg, 180 + 50) # old reserve keys are marked as change now | ||
| assert_equal(found_addr_rsv, 180) # keypool size (TODO: fix off-by-one) |
There was a problem hiding this comment.
There is no off-by-one as far as I see
…ryption-tests) 54af51d [QA] Add walletdump RPC test (including HD- & encryption-tests) (Jonas Schnelli)
fa4439d [qa] Rework hd wallet dump test (MarcoFalke)
e89614b [qa] Add more helpful RPC timeout message (Russell Yanofsky) 8463aaa [qa] Increase wallet-dump RPC timeout (Russell Yanofsky)
bitcoin#8840: test: Explicitly set encoding to utf8 when opening text files
We currently have usehd defaulted to 0, so we need to explicitly start it with usehd=1 in wallet-dump.py. This requires setting up a new data dirs cache for hd as the wallets won't be compatible otherwise. At the same time we need the initial state of the wallet to test the dump functionality. Also use redirect_stderr=True to fix failure when run from pull-tester
…ly keys (on top of bitcoin#9682) a80f98b Use importmulti timestamp when importing watch only keys (Russell Yanofsky) a58370e Dedup nTimeFirstKey update logic (Russell Yanofsky)
…is not marked 'override'" warnings 6c5427d wallet: Prevent "overrides a member function but is not marked 'override'" warnings (Wladimir J. van der Laan)
…ortmulti rescans e662af3 Use 2 hour grace period for key timestamps in importmulti rescans (Russell Yanofsky) 38d3e9e [qa] Extend import-rescan.py to test imports on pruned nodes. (Russell Yanofsky) c28583d [qa] Extend import-rescan.py to test specific key timestamps (Russell Yanofsky) 8be0866 [qa] Simplify import-rescan.py (Russell Yanofsky)
Added a workaround to the masternode+pruning mode check to allow pruning in regtest. The actual bug behind the masternode+pruning check is not touched this way. Please read the linked GitHub issues for details.
…let-dump.py Same as with start_node
codablock
force-pushed
the
pr_backport_hd_wallet
branch
from
523ac51 to
00a0bc7
Compare
|
Pushed a fix for the small review nit. There seem to be unrelated CI failures atm which only sometimes happen. Going through the logs I feel it has something to do with messages being sent before VERSION. This should be fixed by #1882 and thus I rebased on develop and force pushed. Watching for this failure in the future... Then there is still the nasty wine tests timeout... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the previously missed PRs for wallet-dump.py and key timestamp related PRs.