Skip to content

Commit

Permalink
Merge #6525: ci: add nowallet functional tests
Browse files Browse the repository at this point in the history
1646525 ci: add nowallet functional tests (Konstantin Akimov)

Pull request description:

  Many functional tests can be run if Dash Core is built as no-wallet, but we currently do not test whether they actually work in no-wallet mode. Additionally, many functional tests can run with a simple dummy wallet, increasing the number of functional tests that can run without a wallet. However, we also do not test this scenario.

  Now that extra functional tests have become available to run with the dummy-wallet MiniWallet (see #6520), we should finally add a job to our CI pipeline to run functional tests in no-wallet mode.

  Though using MiniWallet for DashTestFramework to let register masternodes without using a real Dash Core wallet currently impossible due to limitation of MiniWallet:

              Note that this method fails if there is no single internal utxo
              available that can cover the cost for the amount and the fixed fee
              (the utxo with the largest value is taken).

  This limitation may be addressed in future PRs, but it is out of scope for this PR.

  ## What was done?
  Add new CI job to run functional tests for nowallet.

  ## How Has This Been Tested?
  See CI: https://gitlab.com/dashpay/dash/-/jobs/8805673945

  ## Breaking Changes
  N/A

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  UdjinM6:
    utACK 1646525
  kwvg:
    utACK 1646525
  PastaPastaPasta:
    utACK 1646525

Tree-SHA512: c93ef92670886d3a5cf835681b55c264c757005c4af3146355e78808ab7e22fee30e5559218808bd381eb0a59bc01cc0ac69ce89dfd2d659e533392c33ac0a6a
  • Loading branch information
PastaPastaPasta committed Jan 11, 2025
2 parents 8debe7b + 1646525 commit 8dac4b1
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,15 @@ linux64_multiprocess-test:
variables:
BUILD_TARGET: linux64_multiprocess

linux64_nowallet-test:
extends:
- .test-template
- .skip-in-fast-mode-template
needs:
- linux64_nowallet-build
variables:
BUILD_TARGET: linux64_nowallet

#linux64_valgrind-test:
# extends:
# - .test-template
Expand Down

0 comments on commit 8dac4b1

Please sign in to comment.