fix: structure validation functions were receiving plain objects inst…

…ead of JSON (#218)

lib/identity/IdentityFactory.js

@@ -62,15 +62,17 @@ class IdentityFactory {
   createFromObject(rawIdentity, options = {}) {
     const opts = { skipValidation: false, ...options };
 
+    const identity = new Identity(rawIdentity);
+
     if (!opts.skipValidation) {
-      const result = this.validateIdentity(rawIdentity);
+      const result = this.validateIdentity(identity.toJSON());
 
       if (!result.isValid()) {
         throw new InvalidIdentityError(result.getErrors(), rawIdentity);
       }
     }
 
-    return new Identity(rawIdentity);
+    return identity;
   }
 
   /**

lib/stateTransition/StateTransitionFactory.js

@@ -54,19 +54,19 @@ class StateTransitionFactory {
   async createFromObject(rawStateTransition, options = {}) {
     const opts = { skipValidation: false, ...options };
 
+    // noinspection UnnecessaryLocalVariableJS
+    const stateTransition = await this.createStateTransition(rawStateTransition, {
+      fromJSON: false,
+    });
+
     if (!opts.skipValidation) {
-      const result = await this.validateStateTransitionStructure(rawStateTransition);
+      const result = await this.validateStateTransitionStructure(stateTransition.toJSON());
 
       if (!result.isValid()) {
         throw new InvalidStateTransitionError(result.getErrors(), rawStateTransition);
       }
     }
 
-    // noinspection UnnecessaryLocalVariableJS
-    const stateTransition = await this.createStateTransition(rawStateTransition, {
-      fromJSON: false,
-    });
-
     return stateTransition;
   }
 

test/unit/stateTransition/StateTransitionFactory.spec.js

@@ -93,8 +93,6 @@ describe('StateTransitionFactory', () => {
         expect(validateStateTransitionStructureMock).to.have.been.calledOnceWith(
           rawStateTransition,
         );
-
-        expect(createStateTransitionMock).to.have.not.been.called();
       }
     });
   });