Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys ↑ and ↓ mapped onto chapters, then on playlist #108

Closed
dascritch opened this issue Feb 22, 2021 · 11 comments
Closed

Keys ↑ and ↓ mapped onto chapters, then on playlist #108

dascritch opened this issue Feb 22, 2021 · 11 comments

Comments

@dascritch
Copy link
Owner

No description provided.

@dascritch
Copy link
Owner Author

dascritch commented Mar 31, 2021

  • Focus plane/point magement
    • el.CPU.focusPoint(planeName,pointName) (focus on plane, else on track, else... error ?)
    • planeAndPointNamesFromId( el.CPU.focusedId() ) => [ planeName, pointName ] or null
    • is there a el.CPU method to get which chapter is played / time positionned ? yes : el.CPU._activecue_id
    • el.CPU.prevFocus() // for key management
    • el.CPU.nextFocus() // for key management
  • util.js, utility to browse in a (supposedly) ordered object
    • util adjacentKey(object, key, offset) // on document.CPU for tests purposes
  • add some trigger, cabled on eventual shadow button
    • trigger prevcue previous chapter
    • trigger nextcue next chapter
    • trigger prevtrack previous track in playlist
    • trigger nexttrack next track in playlist (rewrite trigger event end of track)
  • map key
    • up CPU.el.prevFocus()
    • down CPU.el.nexrFocus()
    • pageup on focusPoint / previousInObj plane
    • pagedown on focusPoint / nextInObj plane

@dascritch
Copy link
Owner Author

dascritch commented Mar 31, 2021

Remark : for keys, we WON'T immediately change audio position, let's way for "enter" key (to check too)

dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ ans ↓ mapped onto chapters, then on playlist #108
@dascritch
Copy link
Owner Author

strangely , element.focus() doesn't gives ":focus" pseudoelement but ":active" . Not what I want, at all

@dascritch
Copy link
Owner Author

Linked to WICG/webcomponents#830 ...????

@dascritch dascritch changed the title Keys ↑ ans ↓ mapped onto chapters, then on playlist Keys ↑ and ↓ mapped onto chapters, then on playlist Apr 2, 2021
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ ans ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ ans ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
@dascritch
Copy link
Owner Author

We need to separate cues (which relly on chapters) and keys ↑ and ↓ , why is about focus between panels

@dascritch
Copy link
Owner Author

prevcue may blink chapter panel, as the download strategy from the browser to go upper in the audio may go a second too early, blinking a previous chapter.

dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
@dascritch
Copy link
Owner Author

dascritch commented Apr 2, 2021

Still a strange bug where a click on playlist make lose focus, so losing ↑ and ↓ keys.
I know why : when you have the playlist panel, you're con the controller. Clicking will give focus to the cpu-audio instance of the chosen audio.
Annoying, but I don't see how elegantely not losing focus .... as it is controlled via an hashchange event ....

@dascritch
Copy link
Owner Author

pageup/pagedown should be used to change cpu-audio / cpu-controller among playlists

dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
dascritch added a commit that referenced this issue Apr 2, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
@dascritch
Copy link
Owner Author

The focus is lost when changing sound in the cpu-controller because we redraw all the panels. Perhaps we mustn't redraw the one linked to the component.

@dascritch
Copy link
Owner Author

Note for later : using "insertAdjacentElement" to move a DOM tree will remove focus to elements.

dascritch added a commit that referenced this issue Apr 3, 2021
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
@dascritch
Copy link
Owner Author

I need an "all possible buttons" theme, with a specific panel in controller for playlist. Mainly for tests and showcases

dascritch added a commit that referenced this issue Apr 9, 2021
… by default

Hidden panels or points should not be key browsable #139
Keys ↑ and ↓ mapped onto chapters, then on playlist #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant