Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use OntologyIri in ontology requests #3481

Merged
merged 49 commits into from
Feb 4, 2025
Merged

refactor: Use OntologyIri in ontology requests #3481

merged 49 commits into from
Feb 4, 2025

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Jan 28, 2025 •
edited
Loading

  • rename KnoraIri.toInternalIri
  • align smartIri methods on KnoraIri and make final
  • use OntologyIri in can delete and delete ontology requests
  • move code from StringFormatter into Domain Value object

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

seakayone and others added 28 commits January 21, 2025 12:39
@seakayone
inline OntologyTriplestoreHelpers trait
73d03e7
@seakayone
inline OntologyCacheHelpers trait
a881072
@seakayone
replace with ZIO.unit
b98ca11
@seakayone
Replace cacheUpdatedOntology(SmartIri,ReadOntologyV2) with refreshing…
f60c558 
… cache from db
@seakayone
replace OntologyCache.deleteOntology with refreshing from DB
1b7f98e
@seakayone
replace OntologyCache.cacheUpdatedOntologyWithClass with refreshing f…
0d786d0 
…rom DB
@seakayone
replace OntologyCache.cacheUpdatedOntologyWithClass with refreshing f…
43598d7 
…rom DB
@seakayone
cleanup
7fb2a43
@seakayone
improve logging
b0e6416
@seakayone
cleanup
68cc849
@seakayone
simplify
09256f5
@seakayone
Merge branch 'main' into fix/ontology-cache
728c5cc
@seakayone
fixup! simplify
08e90f7
@seakayone
fmt
78050e1
@seakayone
Merge branch 'main' into fix/ontology-cache
4f0cee9
@seakayone
Merge branch 'main' into fix/ontology-cache
9dded3e
@seakayone
Merge branch 'main' into fix/ontology-cache
d3346a4
@seakayone
Merge branch 'main' into fix/ontology-cache
2d9e189
@seakayone
Merge branch 'main' into fix/ontology-cache
cdef837
@seakayone
Merge branch 'main' into fix/ontology-cache
43782b5
@seakayone
Merge branch 'main' into fix/ontology-cache
0d158bd
@seakayone
Merge branch 'main' into fix/ontology-cache
c4686c6
@seakayone
Merge branch 'main' into fix/ontology-cache
9600f67
@seakayone
fmt
5ea5f1a
@seakayone
rm unused
085f8a0
@seakayone
rename KnoraIri.toInternalIri
251a9d1
@seakayone
align smartIri methods on KnoraIri and make final
2bc3ae6
@seakayone
use OntologyIri in can delete and delete ontology requests
4fcdf50
@seakayone seakayone changed the base branch from main to fix/ontology-cache January 28, 2025 19:04
@seakayone seakayone changed the title refactor/use ontologyIri refactor: Use ontologyIri in can delete and delete ontology requests Jan 28, 2025
@seakayone seakayone self-assigned this Jan 28, 2025
Base automatically changed from fix/ontology-cache to main January 29, 2025 08:40
@seakayone seakayone changed the title refactor: Use ontologyIri in can delete and delete ontology requests refactor: Use OntologyIri in ontology requests Jan 29, 2025
@seakayone seakayone marked this pull request as ready for review January 29, 2025 10:56
BalduinLandolt
BalduinLandolt approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The changes to the OntologyResponder were a bit hard to read - I hope I didn't miss anything there.

@seakayone seakayone merged commit cebb1ae into main Feb 4, 2025
8 checks passed
@seakayone seakayone deleted the refactor/use-ontologyIri branch February 4, 2025 08:47
@daschbot daschbot mentioned this pull request Feb 3, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@siers siers siers approved these changes

@mpro7 mpro7 Awaiting requested review from mpro7 mpro7 is a code owner

Assignees

@seakayone seakayone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @siers @BalduinLandolt