-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-level ordered lists #18
Conversation
Should I bump version number in the podspec? |
Hi @antoinelamy , Thank you so much for this PR, it is amazing! The list item delegate method is changed, so the code snippet in the readme should change either. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the list item delegate method is changed, the embedded sample should be changed either; it's the ContentView.swift
file in Sample/Shared
.
I updated the sample to give an exemple of a basic ParmaRenderable implementation like the other elements. |
I would be curious to know what is your setup to build this project, I had to manually delete the Down file references pointing to the build directory and add them back as a SPM dependency for the project to compile. I'm pretty sure you don't go over these steps so maybe I'm doing something wrong or maybe it could be documented in the Readme for future contributors. Anyway, great library 👌🏻. |
It's unnecessary to manually do that because a skeleton project has already added, which is the sample project, and it contains the Xcode project of Parma. Use that to build either Parma or the iOS skeleton app, make sure to run Thanks for your advice, and I'll add some contribution messages to the Readme. Great work, thanks! 😊 |
I think it's the |
🎉 Parma 0.3.0 was released! Thanks again 🙌. |
Add support for multi-level ordered lists supporting two types of delimiters: parenthesis and periods.
It also support mix-and-matching delimiters and list styles. As an exemple, the following markdown:
Would produce the following result with the default
![Screen Shot 2021-05-13 at 5 38 48 PM](https://user-images.githubusercontent.com/291573/118191362-7200d400-b412-11eb-914d-a0083496026b.png)
ParmaRenderable
:Notes
The default bullet list style has been updated to switch between
![Screen Shot 2021-05-13 at 5 53 43 PM](https://user-images.githubusercontent.com/291573/118192601-63b3b780-b414-11eb-8450-47c40f2e9684.png)
•
and◦
for better readabilityFixes the additional spacing for multi-level lists when entering a deeper level
![Screen Shot 2021-05-13 at 5 52 35 PM](https://user-images.githubusercontent.com/291573/118192611-67dfd500-b414-11eb-9828-460aee50f5d7.png)