Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.6.7 #497

Merged
merged 24 commits into from
Aug 25, 2020
Merged

Release 0.6.7 #497

merged 24 commits into from
Aug 25, 2020

Conversation

AurevoirXavier
Copy link
Member

@AurevoirXavier AurevoirXavier commented Aug 18, 2020 •
edited
Loading

  • Update Substrate

@AurevoirXavier AurevoirXavier marked this pull request as draft August 18, 2020 12:38
@AurevoirXavier AurevoirXavier mentioned this pull request Aug 18, 2020
Closed
This was linked to issues Aug 18, 2020
Companion for #6745 #494
Closed
Companion for #6782 #495
Closed
@hackfisher
Copy link
Contributor

https://polkadot.network/grandpa-equivocation-and-sysinfo-process-collection-results-in-slashing-on-kusama-network-a-post-mortem/

@AurevoirXavier AurevoirXavier marked this pull request as ready for review August 23, 2020 07:31
@AurevoirXavier
Copy link
Member Author

https://polkadot.network/grandpa-equivocation-and-sysinfo-process-collection-results-in-slashing-on-kusama-network-a-post-mortem/

Darwinia is on Polkadot 0.8.22, Substrate 52494a465ab68904343c0525e86261ebcb166808. I think, it's safe to make an upgrade.

@AurevoirXavier
Copy link
Member Author

Hold on, I'll make a migration to fix the ring/kton pool.

@AurevoirXavier
Copy link
Member Author

Fix slash, correct pool value.

darwinia-network/darwinia-common#248

@AurevoirXavier AurevoirXavier marked this pull request as draft August 24, 2020 19:31
@AurevoirXavier AurevoirXavier marked this pull request as ready for review August 24, 2020 19:31
@AurevoirXavier AurevoirXavier marked this pull request as draft August 25, 2020 02:09
@hackfisher
Copy link
Contributor

hackfisher commented Aug 25, 2020 •
edited
Loading

52494a465ab68904343c0525e86261ebcb166808

Cargo.lock show that substrate version is ed4f7a113073c08cba9020c3f0dd6c8f0441f857, and it seems to be newer than 52494a465ab68904343c0525e86261ebcb166808, should also works?

@AurevoirXavier
Copy link
Member Author

52494a465ab68904343c0525e86261ebcb166808

Cargo.lock show that substrate version is ed4f7a113073c08cba9020c3f0dd6c8f0441f857, and it seems to be newer than 52494a465ab68904343c0525e86261ebcb166808, should also works?

Yes, I'm trying to add evm on this commit. It'll be a little newer.

@hackfisher
Copy link
Contributor

@AurevoirXavier LGTM, the PR is draft status, not reeady for merge now

@AurevoirXavier
Copy link
Member Author

@AurevoirXavier LGTM, the PR is draft status, not reeady for merge now

EVM is on the way.

@AurevoirXavier AurevoirXavier marked this pull request as ready for review August 25, 2020 04:48
@hackfisher hackfisher merged commit 1519f51 into master Aug 25, 2020
@AurevoirXavier AurevoirXavier deleted the xavier-0.6.7 branch August 25, 2020 06:04
boundless-forest pushed a commit that referenced this pull request Aug 1, 2023
@sorpaas
Ensure no error is possible in apply_validated_transaction and fix …
334409c 
…`correct_and_deposit_fee` (#497)

* Ensure no error is possible in `apply_validated_transaction`

* Fix lints

* Fix correct_and_deposit_fee should not be able to error

* Change ensure to assert

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher hackfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Companion for #6782 Companion for #6745
2 participants
@AurevoirXavier @hackfisher