Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate All Warnings in Core Lib #136

Closed
aurexav opened this issue Dec 4, 2019 · 2 comments
Closed

Eliminate All Warnings in Core Lib #136

aurexav opened this issue Dec 4, 2019 · 2 comments
Assignees

Comments

@aurexav
Copy link
Member

aurexav commented Dec 4, 2019

warning: unused import: `crate::std::*`
 --> core/merkle-patricia-trie/src/nibbles.rs:1:5
  |
1 | use crate::std::*;
  |     ^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused import: `crate::std::*`
 --> core/merkle-patricia-trie/src/proof.rs:1:5
  |
1 | use crate::std::*;
  |     ^^^^^^^^^^^^^

warning: unused `std::result::Result` that must be used
  --> core/merkle-patricia-trie/src/lib.rs:72:3
   |
72 |         trie.insert(key.as_ref().to_vec(), value.as_ref().to_vec());
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_must_use)]` on by default
   = note: this `Result` may be an `Err` variant, which should be handled

warning: unused import: `ethbloom::Bloom`
 --> core/sr-eth-primitives/src/pow.rs:8:5
  |
8 | use ethbloom::Bloom;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused imports: `H160`, `U128`
  --> core/sr-eth-primitives/src/pow.rs:12:23
   |
12 | use primitive_types::{H160, H256, U128, U256, U512};
   |                       ^^^^        ^^^^

warning: unused variable: `progpow`
   --> core/sr-eth-primitives/src/pow.rs:282:82
    |
282 | fn quick_get_difficulty(header_hash: &[u8; 32], nonce: u64, mix_hash: &[u8; 32], progpow: bool) -> [u8; 32] {
    |                                                                                  ^^^^^^^ help: consider prefixing with an underscore: `_progpow`
    |
    = note: `#[warn(unused_variables)]` on by default
@aurexav aurexav changed the title Eliminate All Warning in Core Lib Eliminate All Warnings in Core Lib Dec 4, 2019
@aurexav aurexav added this to the Darwinia Ice Frog Testnet milestone Dec 4, 2019
@aurexav
Copy link
Member Author

aurexav commented Dec 6, 2019

warning: unused `std::result::Result` that must be used
  --> core/merkle-patricia-trie/src/lib.rs:49:3
   |
49 |         trie.insert(key.as_ref().to_vec(), value.as_ref().to_vec());
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_must_use)]` on by default
   = note: this `Result` may be an `Err` variant, which should be handled

@aurexav aurexav reopened this Dec 6, 2019
@aurexav
Copy link
Member Author

aurexav commented Dec 10, 2019

warning: unused import: `ethbloom::Bloom`
   --> core/sr-eth-primitives/src/receipt.rs:122:6
    |
122 |     use ethbloom::Bloom;
    |         ^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

warning: unused import: `triehash::ordered_trie_root`
   --> core/sr-eth-primitives/src/receipt.rs:128:6
    |
128 |     use triehash::ordered_trie_root;
    |         ^^^

@aurexav aurexav assigned aurexav and unassigned hackfisher Dec 10, 2019
@aurexav aurexav mentioned this issue Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants