Merge branch 'denny_fixing_ethereum_bridge' into develop

darwinia-network · Dec 7, 2019 · 141daf5 · 141daf5
2 parents 4d8fc9e + 7eff857
commit 141daf5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/srml/eth-relay/src/lib.rs b/srml/eth-relay/src/lib.rs
@@ -86,7 +86,7 @@ decl_storage! {
 			if let Some(h) = &config.header {
 				let header: EthHeader = rlp::decode(&h).expect("Deserialize Header - FAILED");
 
-				<Module<T>>::genesis_header(&header,config.genesis_difficulty);
+				<Module<T>>::init_genesis_header(&header,config.genesis_difficulty);
 
 				// TODO: initilize other parameters.
 			}
@@ -106,7 +106,7 @@ decl_module! {
 			// TODO: Check authority
 
 			// TODO: Just for easy testing.
-			Self::genesis_header(&header, genesis_difficulty);
+			Self::init_genesis_header(&header, genesis_difficulty);
 
 			<Module<T>>::deposit_event(RawEvent::NewHeader(header));
 		}
@@ -159,7 +159,7 @@ decl_event! {
 
 impl<T: Trait> Module<T> {
 	// TOOD: what is the total difficulty for genesis/begin header
-	pub fn genesis_header(header: &EthHeader, genesis_difficulty: u64) {
+	pub fn init_genesis_header(header: &EthHeader, genesis_difficulty: u64) {
 		let header_hash = header.hash();
 		let block_number = header.number();
 
@@ -216,6 +216,7 @@ impl<T: Trait> Module<T> {
 		let parent_hash = header.parent_hash();
 
 		let number = header.number();
+
 		ensure!(
 			number >= Self::begin_header().expect("Begin Header - NOT EXISTED").number(),
 			"Block Number - TOO SMALL"

diff --git a/srml/eth-relay/src/tests.rs b/srml/eth-relay/src/tests.rs
@@ -76,7 +76,7 @@ fn verify_receipt_proof() {
 				hash: Some(H256::from(hex!("f1a5bc27877e219b859b0bb1f2f440134553019f9bb5a2eca7a4703263e736c9"))),
 			};
 
-			EthRelay::genesis_header(&header, 0x624c22d93f8e59_u64);
+			EthRelay::init_genesis_header(&header, 0x624c22d93f8e59_u64);
 
 			assert_eq!(EthRelay::verify_receipt(&proof_record), Some(receipt));
 		});
@@ -131,7 +131,7 @@ fn relay_header() {
 		};
 
 
-		EthRelay::genesis_header(&header1, 0x624c22d93f8e59_u64);
+		EthRelay::init_genesis_header(&header1, 0x624c22d93f8e59_u64);
 
 		EthRelay::verify_header(&header2).expect("Verify Failed.");