This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Prepare for Crab<>Crab Parachain #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
hackfisher
reviewed
May 17, 2022
|
|
||
| #![cfg_attr(not(feature = "std"), no_std)] | ||
|
|
||
| mod copy_paste_from_darwinia { |
There was a problem hiding this comment.
This name is the same with other bp-xxx :
Comment on lines
+31
to
+32
| spec_version: 4, | ||
| impl_version: 1, |
There was a problem hiding this comment.
How this settings be used? What if crab parachain's spec changes?
There was a problem hiding this comment.
Bridger has a startegy related to this setting. If the strategy is Auto, bridger will try to use the latest spec version on the Crab, and ignore this setting. If the strategy is Bundle, bridger will use this setting to communicate with Crab. And if the strategy is Custom, bridger can custom spec_version with the local config file.
CC @fewensa
There was a problem hiding this comment.
Clean and move this to bridger if it is only used by bridger.
furoxr
added a commit
that referenced
this pull request
Jun 1, 2022
* Add PARAS_PALLET_NAME to bp-kusama * Add bp-crab-parachain * Add relay-crab-parachain-client * Add CRAB_PARACHAIN_CHAIN_ID crap * Update lane id
AurevoirXavier
pushed a commit
that referenced
this pull request
Jun 1, 2022
* Add PARAS_PALLET_NAME to bp-kusama * Add bp-crab-parachain * Add relay-crab-parachain-client * Add CRAB_PARACHAIN_CHAIN_ID crap * Update lane id
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.