This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e919661
to
bc5e5ae
Compare
bc5e5ae
to
b656329
Compare
Closed
hackfisher
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but require more decription and campanion frontier PR.
xiaoch05
reviewed
Jul 16, 2021
aurexav
reviewed
Jul 19, 2021
<Pallet<T>>::store_block( | ||
dp_consensus::find_pre_log(&<frame_system::Pallet<T>>::digest()).is_err(), | ||
U256::from(UniqueSaturatedInto::<u128>::unique_saturated_into( | ||
frame_system::Pallet::<T>::block_number(), | ||
)), | ||
); | ||
// move block hash pruning window by one block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aurexav
approved these changes
Jul 19, 2021
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is mainly used for synchronizing changes from 399 to 410 in the upstream library.