-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix line folding #87
Merged
Merged
Fix line folding #87
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f3886e6
Fix line folding to match specification
kekavc24 d46f402
Add test case and remove TODO for fix
kekavc24 c8c1695
Remove indent creation from utility function
kekavc24 51cc41d
Update changelog
kekavc24 c1a4d0a
Return null if strings cannot be encoded in desired `ScalarStyle`
kekavc24 2a2952b
Clean up code
kekavc24 60f9ae5
Remove unnecessary assertions and add docs
kekavc24 73af9d2
Minor refactoring
jonasfj df86c7d
Fix condition check for encoding as literal/folded
kekavc24 a9b5f6a
Remove keep chomping indicator references
kekavc24 53d0641
Update lib/src/strings.dart
jonasfj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to file this as a separate PR, if you want. Then we get to land it quickly :D
Tagging it along here is harmless though.